[darcs-users] [patch204] Make issue1739 test skip instead of fail on non-UTF-8 ...

[Petr Rockai]

Eric Kow <kowey at darcs.net> writes:

> On Tue, Apr 06, 2010 at 08:49:19 +0100, Eric Kow wrote:
>> On Mon, Apr 05, 2010 at 20:01:03 +0000, Reinier Lamers wrote:
>> > Mon Apr  5 20:23:39 CEST 2010  Reinier Lamers <tux_rocker at reinier.de>
>> >   * Make issue1739 test skip instead of fail on non-UTF-8 locales
>> 
>> Reinier's justification for this patch (non-UTF-8 behaviour already
>> covered elsewhere) seems to make sense, so I'll go ahead and push this.
>
> Actually, another approach, instead of disabling the test, might be
> to can the message.  Write it offline (outside of the test), save it
> to the darcs darcs repo and read it back in during the test.
You can't. The echo that is there already is equivalent to what you
propose. The problem is that darcs treats the file as
locale-encoded. This probably makes sense. Specifically, if it contained
invalid utf8, this would create a loophole in our utf8 metadata and we'd
be back to the original problem (just rarer, since it'd only trigger on
--logfile and possibly editing the long comment...).

Yours,
   Petr.