[darcs-users] [patch358] resolve issue1815: generate tarballs with the right permissions

[Reinier Lamers]

New submission from Reinier Lamers <tux_rocker at reinier.de>:

'runghc Setup.lhs sdist' generates tarballs with whacky permissions (Cabal
issue 627 [1]). 'cabal sdist' gets the permissions right but does not allow 
you
to have automatically generated modules (Cabal issue 729 [2]). We have
automatically generated modules so we can't use 'cabal sdist'. So the release
scripts now untars the tarball, adjust permissions, and tars it up again.

[1]: http://hackage.haskell.org/trac/hackage/ticket/627
[2]: http://hackage.haskell.org/trac/hackage/ticket/729

Reinier

----------
files: resolve-issue1815.dpatch
messages: 12268
nosy: tux_rocker
status: needs-review
title: resolve issue1815: generate tarballs with the right permissions

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch358>
__________________________________
-------------- next part --------------
'runghc Setup.lhs sdist' generates tarballs with whacky permissions (Cabal
issue 627 [1]). 'cabal sdist' gets the permissions right but does not allow you
to have automatically generated modules (Cabal issue 729 [2]). We have
automatically generated modules so we can't use 'cabal sdist'. So the release
scripts now untars the tarball, adjust permissions, and tars it up again.

[1]: http://hackage.haskell.org/trac/hackage/ticket/627
[2]: http://hackage.haskell.org/trac/hackage/ticket/729

1 patch for repository http://darcs.net/:

Sun Aug 22 21:13:24 CEST 2010  Reinier Lamers <tux_rocker at reinier.de>
  * resolve issue1815: work around Cabal sdist permissions issue


New patches:

[resolve issue1815: work around Cabal sdist permissions issue
Reinier Lamers <tux_rocker at reinier.de>**20100822191324
 Ignore-this: 2817046dba4594569a94f812ef09c81f
] hunk ./release/release.sh 41
 
 cd /tmp
 tar xvzf $wd/dist/$tarballname
+
+# fix tarball permissions (Cabal bug 627)
+# we can't use 'cabal sdist' as a workaround because we have our own sdist hook
+find $packagename -type f -exec chmod 644 {} +
+find $packagename -type d -exec chmod 755 {} +
+
+tar czf $tarballname $packagename
+
+test -f $tarballname
+cp -f $tarballname $wd/dist/$tarballname
+
+# okay, permissions fixed, test if we can build and test from the tarball
+tar xvzf $wd/dist/$tarballname
 cd $packagename
 
 runghc Setup configure --user -ftype-witnesses -ftest

Context:

[Fix tests that were broken by issue1898 fix.
Eric Kow <kowey at darcs.net>**20100815202529
 Ignore-this: f25c2aaed8c0063cee2f31c179345190
 These tests were confused by Darcs UI messages.
] 
[Fix tests that were broken by issue1875 fix.
Eric Kow <kowey at darcs.net>**20100815202223
 Ignore-this: bd6e7066799e39f3529a485f6fbeed42
 
 The tests were assuming --set-default.  As these are artifical repositories for
 test cases, we sometimes have cases where we pull/push from freshly created
 repositories with no defaultrepo.
] 
[Resolve issue1898: notify user when they can use set-default.
Eric Kow <kowey at darcs.net>**20100812155901
 Ignore-this: 638b575b32d700cfae9f057293cd5aa8
] 
[Fix the remote-repo flag if it's not a URL.
Eric Kow <kowey at darcs.net>**20100812150920
 Ignore-this: 10082e2dc200ece25ece1519242962e2
 The word 'fix' here refers to the filepath canonicalisation mechanism
 that makes it easier to check filepath equality.
] 
[Resolve issue1875: avoid accidentally setting default.
Eric Kow <kowey at darcs.net>**20100812154847
 Ignore-this: d03cfc6111805515ae4f1ca467beab2c
 Two cases fixed:
  - setting default on dry-run
  - setting default on darcs get --no-set-default
] 
[Generalise issue1875 test on not setting default.
Eric Kow <kowey at darcs.net>**20100812154827
 Ignore-this: 127842d85545f411ce71e8d065d2c268
] 
[Accept issue1875: darcs does not honor no-set-default on fetch.
Eric Kow <kowey at darcs.net>**20100812152637
 Ignore-this: 32573c47c25ec3e5ad187a5537f50c73
] 
[Accept issue1898: set-default notification system.
Eric Kow <kowey at darcs.net>**20100811141903
 Ignore-this: d33212de428eaf5e2fd85aa4a6cc644a
] 
[TAG 2.4.98.3
Reinier Lamers <tux_rocker at reinier.de>**20100815194519
 Ignore-this: e3a3c30d7dd2fbe49c846c48510a9c3c
] 
Patch bundle hash:
39a516c4d75f72dafb559c0f35dca73656d9dfa0