[darcs-users] [patch370] fix warnings in tests (and 25 more)

Ganesh Sittampalam bugs at darcs.net
Thu Aug 26 23:30:50 UTC 2010


New submission from Ganesh Sittampalam <ganesh at earth.li>:

Hi,

While waiting around for a delivery[1], I did a bit of refactoring.
The main goal is to reorganise darcs v1 and v2 patches into their
own namespaces and to move towards a point where they just implement
a common interface - though we're some way off that ideal yet.

As quite a few files are touched, fast review would be good to
minimise conflicts for all concerned. The first set of patches
is just a bunch of fixes for warnings that show up more obviously
in the tests and the witnesses builds now that Jason has had
a go at the warnings in the main build.

Cheers,

Ganesh

[1] http://urchin.earth.li/aegean/baby/

26 patches for repository http://darcs.net:

Thu Aug 26 10:22:45 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * fix warnings in tests

Thu Aug 26 10:42:24 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * fix warnings in Darcs.Commands.Pull

Thu Aug 26 10:42:47 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * fix warnings in Darcs.Commands.Push

Thu Aug 26 10:44:28 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * fix warnings in Darcs.Commands.Record

Thu Aug 26 10:44:36 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * fix warnings in Darcs.Commands.Send

Thu Aug 26 10:45:19 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * fix warning in Darcs.Patch.Choices

Thu Aug 26 10:45:36 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * fix warning in Darcs.Patch.Depends

Thu Aug 26 10:45:45 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * fix warning in Darcs.Repository.Repair

Thu Aug 26 10:45:53 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * fix warnings in Darcs.Witnesses.Ordered

Thu Aug 26 10:51:13 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * fix warnings in Darcs.Commands.Apply

Thu Aug 26 10:51:22 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * fix warnings in Darcs.SelectChanges

Thu Aug 26 11:44:27 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * start on moving v1 patch code into its own namespace

Thu Aug 26 11:44:37 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * remove unused re-export

Thu Aug 26 11:44:37 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * move RealPatch into its own namespace

Thu Aug 26 12:01:34 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * move Darcs.Patch.Commute into V1 namespace

Thu Aug 26 12:01:40 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * move Named instances out of V1.Commute

Thu Aug 26 12:01:41 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * Darcs.Patch.Core now just contains Named

Thu Aug 26 13:21:37 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * move v1 Patch reading into separate module

Thu Aug 26 13:21:40 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * move v1 Patch applying into separate module

Thu Aug 26 13:33:46 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * get rid of apparently unnecessary instance dependency
  showContextPatch for Prim was sometimes constructing a Patch
  (with the PP constructor) for no apparent reason, as the end result
  would be to show the underlying Prim again.
  

Thu Aug 26 13:55:37 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * break Patch-specific bits of Show and Viewing out into V1

Thu Aug 26 14:27:58 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * drop some exports from Darcs.Patch
  Made imports go directly to the internal modules where necessary,
  on the grounds that it's better to be explicit when making use of
  internal operations.
  

Thu Aug 26 14:36:02 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * get rid of unnecessary superclass

Thu Aug 26 14:58:50 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * split up the Commute class
  Note that Prim is not an instance of the new Merge class,
  which reflects reality as Prims cannot always be merged.
  

Thu Aug 26 16:52:38 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * don't export Patch/RealPatch from Darcs.Patch
  This gets us closer to separating specific implementations from
  the interface.
  

Fri Aug 27 00:24:36 BST 2010  Ganesh Sittampalam <ganesh at earth.li>
  * move some Patchy instances into a separate file

----------
files: fix-warnings-in-tests.dpatch, unnamed
messages: 12325
nosy: ganesh
status: needs-review
title: fix warnings in tests (and 25 more)

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch370>
__________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-warnings-in-tests.dpatch
Type: text/x-darcs-patch
Size: 137416 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-users/attachments/20100826/4ed48dbf/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unnamed
Type: application/octet-stream
Size: 5 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-users/attachments/20100826/4ed48dbf/attachment-0001.obj>


More information about the darcs-users mailing list