[darcs-users] Doubts about commuteFilepatches
iago.abal at gmail.com
Tue Dec 7 18:06:06 UTC 2010
Today I comment out that two cases and I run "darcs-test --unit=yes" without
any failing test.
Maybe that's interesting (or maybe not).
On Tue, Nov 23, 2010 at 5:12 PM, Iago Abal <iago.abal at gmail.com> wrote:
> Yes, I'm talking about this two cases.
> On Tue, Nov 23, 2010 at 5:02 PM, Ian Lynagh <igloo at earth.li> wrote:
>> On Tue, Nov 23, 2010 at 01:25:01PM +0000, Iago Abal wrote:
>> > What commuteFP does is just trivially commute any id-hunk (stupid-hunk
>> > not seem a good name, since they make sense), and this is definetly
>> > (at least in theory, since effect-preserving is no longer true). So you
>> > right Eric, Darcs could end up trying to apply a Hunk f 20   when f
>> > 10 lines.
>> You're talking about these, right?:
>> commuteFP f (Hunk line1   :< p2) =
>> seq f $ Succeeded (FP f (unsafeCoerceP p2) :< FP f (Hunk line1  ))
>> commuteFP f (p2 :< Hunk line1  ) =
>> seq f $ Succeeded (FP f (Hunk line1  ) :< FP f (unsafeCoerceP p2))
>> These look wrong to me too. If nothing else, I'd expect them to update
>> the line numbers in the Hunk/Hunk case.
>> darcs-users mailing list
>> darcs-users at darcs.net
> Iago Abal Rivas
Iago Abal Rivas
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the darcs-users