[darcs-users] [patch311] remove duplicate code, readPatchIds [status=amend-requested]

Eric Kow kowey at darcs.net
Thu Jul 22 10:14:06 UTC 2010


On Thu, Jul 22, 2010 at 07:02:47 +0000, Jason Dagit wrote:
> Thu Jul 22 00:03:42 PDT 2010  Jason Dagit <dagit at codersbase.com>
>   * remove duplicate code, readPatchIds

I think you may have forgotten to export readPatchIds from
Darcs.Repository.DarcsRepo

But then here's a situation I don't know how to handle:

1) Is it appropriate for DarcsRepo to export a readPatchIds function?
2) If not, which is the lesser evil?  The inappropriate export or the
   code duplication? (or I suppose some third solution, like moving
   the function to a more appropriate place)

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
For a faster response, please try +44 (0)1273 64 2905.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.osuosl.org/pipermail/darcs-users/attachments/20100722/694bafd2/attachment.pgp>


More information about the darcs-users mailing list