[darcs-users] [patch278] Make the tests for dont-prompt-deps use -i

Eric Kow kowey at darcs.net
Fri Jun 11 17:13:54 UTC 2010


Make the tests for dont-prompt-deps use -i
------------------------------------------
> Florent Becker <florent.becker at ens-lyon.org>**20100611163130
>  Ignore-this: 3f24c1e9a24774842f95517ff22e6ad2
>  The old tests tested 'darcs foo --match $matcher --all' instead of
>  'darcs foo -match $matcher --dont-prompt' because of dry-run.
> ] hunk ./tests/pull-dont-prompt-deps.sh 25
>  echo bar2 > b
>  darcs record -Ax -alm bar2
>  cd ../temp2
> -echo y | darcs pull ../temp1 --dont-prompt-for-dependencies -p foo2 --dry-run > toto
> -#on the previous line, we don't get asked about foo1.
> -grep foo toto | wc -l | grep 2
> -#but we send it anyway.
> +echo y | darcs pull ../temp1 -i --dont-prompt-for-dependencies -p foo2 --dry-run > toto
> +#on the previous line, we get asked about foo2, and we take it
> +grep foo2 toto | wc -l | grep 2
> +#we don't get asked about foo1, but we take it anyway, so 
> +grep foo1 toto | wc -l | grep 1
> +#and we don't send bar

I'm not 100% clear on what this is for (was the test just not testing
enough because it was accidentally using --all, as you said?), but it
seems fine.

I'm guessing it may be better to test the wc -l output for string
equality instead of using grep but it doesn't matter much.

To be applied on my next round of pushes.

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.osuosl.org/pipermail/darcs-users/attachments/20100611/324d9f42/attachment.pgp>


More information about the darcs-users mailing list