[darcs-users] [patch277] Resolve issue 1176: caches interfere with --remote-rep...

[Eric Kow]

On Sun, Jun 13, 2010 at 20:06:13 +0000, Adolfo Builes wrote:
> -      addLocal repo repos = modifyCache repo $ \ (Ca cache) -> Ca $ [Cache DarcsCache.Repo NotWritable r | r <- repos, isFile r ] ++ cache
> +      addRepos repo repos = modifyCache repo $ \ (Ca cache) -> Ca $ [ toCache r | r <- repos ] ++

Hmm, now you're adding all the explicitly requested repos (which is
fine), but you're sorting them... shouldn't these be sorted in locality
order?

> +      toCache r = Cache DarcsCache.Repo NotWritable r

Maybe this should be called toReadOnlyCache if you're amending anyway

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-users/attachments/20100613/b54caeb0/attachment.pgp>