[darcs-users] [patch285] Rename optionFromDarcsoption to optionFr... (and 2 more)

Eric Kow bugs at darcs.net
Fri Jun 25 15:51:45 UTC 2010


Eric Kow <kowey at darcs.net> added the comment:

Hi Florent,

Would you mind reviewing this?  (I feel a bit guilty about shifting UI
stuff to you since I'd like to avoid hyper-specialisation and improve
bus-factor robustness).

Not sure if you see where I'm going with this.

Rejecting the main bits of this bundle may be the wisest move, as there
is a strong chance I'm barking up the wrong tree with this
DarcsMutuallyExclusiveOption business.

I was really just trying to find the best way (in the long term) to get
the default switches flipped.  On the one hand, this may be silly, since
one should not be flipping default switches very much.  On the other
hand, anything we could do to make the code more transparent should be a
bonus...

One bit of trouble I may run into is when you have flags with optional
or required arguments instead of NoArg.  You can't just compare equality
on DarcsFlag because the constructors you're passing around functions
:-/  I suppose I may end up having something that only works with NoArg
cases and not bother with the rest.  [I forget why I think this is a
problem, just making a note of it now]

----------
assignedto:  -> galbolle
nosy: +galbolle

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch285>
__________________________________


More information about the darcs-users mailing list