[darcs-users] [patch442] remove all tests related to checkpoints ... (and 3 more)

gh bugs at darcs.net
Sat Nov 6 16:58:02 UTC 2010


gh <guillaumh at gmail.com> added the comment:

No opinions, at least on the patch that removes "get --ephemeral" ?

Having such a command that creates broken repositories does not look
very serious, unless I am not aware of a particuliar use that someone
may know about...

guillaume


2010/11/1 gh <bugs at darcs.net>:
>
> New submission from gh <guillaumh at gmail.com>:
>
> * remove get --ephemeral support
>
> This patch removes support for get --ephemeral.
>
> Currently, getting a repository with --ephemeral yields a broken
> repository (it is impossible to do a darcs whatsnew inside it for
> instance). This flag is hardly documented anywhere and seems superseeded
> by the --lazy flag. Hence the removal.
>
> * remove support for get --partial and check --partial
>
> This patch removes support for checkpoints.
> Checkpoints are a feature of old-fashioned repositories that make
> getting faster. In modern repositories they no longer exist, and
> get --lazy is recommended to get a similar effect.
>
> Checkpoint creation has already been removed from the Darcs codebase
> since a while.
> What the present patch removes is the following set of commands:
>
> get --partial
> check --partial
> check --complete (no longer makes sense now)
>
> With this patch, Darcs just ignores checkpoints, so it always gets
> and checks completely OF repositories.
>
> Removing this code is a baby step towards old-fashioned support removal.
>
> However in Darcs.Commands.Optimize, I left the lines that detect
> and remove the "checkpoints" subdir in the function that upgrades
> repos from old-fashined to Hashed, so checkpoints are still cleaned
> when upgrading.
>
> 4 patches for repository http://darcs.net:
>
> Mon Nov  1 11:03:24 CET 2010  Guillaume Hoffmann <guillaumh at gmail.com>
>  * remove all tests related to checkpoints and --partial
>
> Mon Nov  1 11:16:02 CET 2010  Guillaume Hoffmann <guillaumh at gmail.com>
>  * remove get --ephemeral support
>
> Mon Nov  1 11:26:29 CET 2010  Guillaume Hoffmann <guillaumh at gmail.com>
>  * remove support for get --partial and check --partial
>
> Mon Nov  1 11:30:30 CET 2010  Guillaume Hoffmann <guillaumh at gmail.com>
>  * fix warnings following --partial removal
>
> ----------
> files: remove-all-tests-related-to-checkpoints-and-__partial.dpatch, unnamed
> messages: 12860
> nosy: gh
> status: needs-screening
> title: remove all tests related to checkpoints ... (and 3 more)
>
> __________________________________
> Darcs bug tracker <bugs at darcs.net>
> <http://bugs.darcs.net/patch442>
> __________________________________

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch442>
__________________________________


More information about the darcs-users mailing list