[darcs-users] [patch454] resolve issue332: ask if test fails

[Sittampalam, Ganesh]

Gabriel Kerneis wrote:
> Gabriel Kerneis <kerneis at pps.jussieu.fr> added the comment:
> 
> Addressing your concerns:
> - I try as much as possible to separate refactoring and new
> functionality, but I couldn't manage to get a refactoring-only patch
> which would make sense (both aspects are intimately tied together). 
> If you have any idea on a sensible split, do not hesitate to unrecord
> my patch and re-record it as two separate patches.

My naïve expectation was that moving the testing calls out of finalizeRepositoryChanges could be separated from prompting on failure, but I could well be wrong. It's certainly not worth a huge amount of effort.
 
> - I am willing to factor out prompting, but I think it should be part
> of a larger work on refactoring how prompting is done in darcs.  It
> has been discussed a bit on IRC, but I think it deserves a separate
> issue to decide how it should be done.   

Fair enough.

Cheers,

Ganesh

=============================================================================== 
Please access the attached hyperlink for an important electronic communications disclaimer: 
http://www.credit-suisse.com/legal/en/disclaimer_email_ib.html 
===============================================================================