[darcs-users] [patch407] hook env vars: add some haddocks (and 3 more)
Ganesh Sittampalam
bugs at darcs.net
Sat Oct 9 15:18:46 UTC 2010
Ganesh Sittampalam <ganesh at earth.li> added the comment:
> Fri Oct 1 14:58:02 PDT 2010 Simon Michael <simon at joyful.com>
> * hook env vars: add some haddocks
> Fri Oct 1 16:29:09 PDT 2010 Simon Michael <simon at joyful.com>
> * hook env vars: haddock improvement
These two look fine and I've pushed them.
> Fri Oct 1 15:01:49 PDT 2010 Simon Michael <simon at joyful.com>
> * hook env vars: clarify some conditional code
I don't understand the point of this - you've moved some code that's
only used under #ifndef WIN32 outside the scope of that guard. Won't
that just make warnings on WIN32?
> Fri Oct 1 15:56:02 PDT 2010 Simon Michael <simon at joyful.com>
> * hook env vars: rename defineChanges/definePatches for clarity
This depends on the previous patch so is stuck for now. Otherwise it's
fine.
__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch407>
__________________________________
More information about the darcs-users
mailing list