[darcs-users] performance regression in annotate darcs 2.4.4 -> darcs 2.4.98

[Eric Kow]

On Tue, Aug 31, 2010 at 17:22:31 -0600, Zooko O'Whielacronx wrote:
> zooko at tahoe-lafs:~/playground/darcs/bench$ darcs-benchmark run -v
> --converge darcs-2.4.4 darcs-2.4.98.3+175
> WARNING: Could read /home/zooko/.darcs-benchmark/tahoe-lafs.org-warm.info
> darcs-benchmark: user error (Pattern match failure in do expression at
> source/Benchmark.hs:178:7-21)

Argh, sorry about that!  I had tried it, just not using the same
version of Darcs as you did

I'll note that this is looks like a standard pattern-match failure that
you'd check type checking for, but when we pattern match out of an
action, we don't get GHC reminding us that this there are missing cases
(ie. ones where splitOn returns not exactly 2 results).

  [info, context] <- splitOn "Context:\n\n" `fmap` darcsMeta cmd ["--exact-version"]

I'm not sure what is the right conclusion to draw from this.
Personally, I'd embrace the type checker and avoid constructs that
suppress its ability to complain...

I'll look into this sometime later.

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
For a faster response, try +44 (0)1273 64 2905 or
xmpp:kowey at jabber.fr (Jabber or Google Talk only)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.osuosl.org/pipermail/darcs-users/attachments/20100901/113bb67e/attachment.pgp>