[darcs-users] vc-darcs.el records changes without the fullname unlike darcs itself (with a PATCH)
Ivan Zakharyaschev
imz at altlinux.org
Tue Dec 15 07:20:57 UTC 2015
On Tue, 15 Dec 2015, Ivan Zakharyaschev wrote:
> Another problem I've noticed with the vc-darcs.el from jch@ is that it
> doesn't use the author's fullname when recording changes.
>
> This has been discovered thanks to a warning by "darcs amend".
>
> Let's have a look how the code of vc-darcs.el could be fixed. (I'll
> post if I come up with something.)
I've pushed my fix to http://hub.darcs.net/imz/vc-darcs_jch .
(Before that I had to convert to darcs-2 to be able to push to
hub.darcs.net, so that might be considered a temporary darcs-2 repo to
publish the fixes until Juliusz converts his one.)
> Hence, the suggested fix:
>
> diff -rN -u old-vc-darcs/vc-darcs.el new-vc-darcs/vc-darcs.el
> --- old-vc-darcs/vc-darcs.el 2015-12-15 07:47:00.563953863 +0300
> +++ new-vc-darcs/vc-darcs.el 2015-12-15 07:47:00.563953863 +0300
> @@ -97,12 +97,13 @@
> : group 'vc-darcs)
>
> (defcustom vc-darcs-mail-address
> - (or (getenv "DARCS_EMAIL")
> - (getenv "EMAIL")
> - (if (string-match "<" user-mail-address)
> - user-mail-address
> - (format "%s <%s>"
> - (user-full-name) user-mail-address)))
> + (let ((addr (or (getenv "DARCS_EMAIL")
> + (getenv "EMAIL")
> + user-mail-address)))
> + (if (string-match "<" addr)
> + addr
> + (format "%s <%s>"
> + (user-full-name) addr)))
> "*The email address to use in darcs."
> : type '(choice string (const nil))
> : group 'vc-darcs)
Best regards,
Ivan
More information about the darcs-users
mailing list