[Intel-wired-lan] [net-next 23/25] fm10k: reset head instead of calling update_max_size
Singh, Krishneil K
krishneil.k.singh at intel.com
Tue Apr 14 19:51:02 UTC 2015
-----Original Message-----
From: Kirsher, Jeffrey T
Sent: Friday, April 3, 2015 2:07 PM
To: intel-wired-lan at lists.osuosl.org
Cc: Keller, Jacob E; Singh, Krishneil K
Subject: Re: [net-next 23/25] fm10k: reset head instead of calling update_max_size
On Fri, 2015-04-03 at 13:27 -0700, Jeff Kirsher wrote:
> When we forcefully shutdown the mailbox, we then go about resetting
> max size to 0, and clearing all messages in the FIFO. Instead, we
> should just reset the head pointer so that the FIFO becomes empty,
> rather than changing the max size to 0. This helps prevent increment
> in tx_dropped counter during mailbox negotiation, which is confusing
> to viewers of Linux ethtool statistics output.
>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher at intel.com>
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> Acked-by: Matthew Vick <matthew.vick at intel.com>
> ---
> drivers/net/ethernet/intel/fm10k/fm10k_mbx.c | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)
I have applied to my queue.
--
git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git
dev-queue
Tested-by: Krishneil Singh <krishneil.k.singh at intel.com>
More information about the Intel-wired-lan
mailing list