[Intel-wired-lan] [PATCH net] i40e: Implement ndo_features_check()

[Jesse Gross]

On Tue, Apr 14, 2015 at 5:02 PM, Jeff Kirsher
<jeffrey.t.kirsher at intel.com> wrote:
> On Tue, 2015-04-14 at 16:35 -0700, Jesse Gross wrote:
>> +/**
>> + * i40e_features_check - Validate encapsulated packet conforms to
>> limits
>> + * @skb: skb buff
>> + * @netdev: This physical port's netdev
>> + * @features: Offload features that the stack believes apply
>> + **/
>> +#define I40E_MAX_TUNNEL_HDR_LEN                80
>> +static netdev_features_t i40e_features_check(struct sk_buff *skb,
>> +                                            struct net_device *dev,
>> +                                            netdev_features_t
>> features)
>> +{
>
> Minor nitpick, although I am not sure what the precedence is.  I
> personally do not like putting the define between the function header
> comment and the function.  I would prefer the #define above the header
> comment.
>
> But if you can find a reason otherwise, I will listen.

No particular reason, I just sent a v2 with this change.