[Intel-wired-lan] [PATCH 1/3] igb: Pull timestamp from fragment before adding it to skb

Brown, Aaron F aaron.f.brown at intel.com
Tue May 5 18:34:44 UTC 2015


> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Alexander Duyck
> Sent: Wednesday, April 22, 2015 9:49 PM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Cong Wang
> Subject: [Intel-wired-lan] [PATCH 1/3] igb: Pull timestamp from fragment
> before adding it to skb
> 
> This change makes it so that we pull the timestamp from the fragment
> before
> we add it to the skb.  By doing this we can avoid a possible issue in
> which
> the fragment can possibly be less than IGB_RX_HDR_LEN due to the timestamp
> being pulled after the copybreak check.
> 
> While making this change I realized we could also pull the rest of the
> igb_pull_tail function into igb_add_rx_frag since in the case of igb,
> unlike ixgbe, we are able to unmap the entire buffer before calling
> add_rx_frag so merging the two allows for sharing of code between the two
> merged functions.
> 
> Reported-by: Cong Wang <xiyou.wangcong at gmail.com>
> Signed-off-by: Alexander Duyck <alexander.h.duyck at redhat.com>
> ---
>  drivers/net/ethernet/intel/igb/igb_main.c |   94 ++++++++----------------
> -----
>  1 file changed, 25 insertions(+), 69 deletions(-)

Tested-by: Aaron Brown <aaron.f.brown at intel.com>


More information about the Intel-wired-lan mailing list