[Intel-wired-lan] [PATCH v1 net-next 1/2] igb: add PHY support for Broadcom 5461S

Tim Harvey tharvey at gateworks.com
Thu May 7 16:32:24 UTC 2015


On Thu, May 7, 2015 at 4:49 AM, Jeff Kirsher
<jeffrey.t.kirsher at intel.com> wrote:
> On Fri, 2015-04-17 at 13:23 -0700, Jonathan Toppins wrote:
>> From: Alan Liebthal <alanl at cumulusnetworks.com>
>>
>> The Quanta LY8 Ethernet management port uses a Broadcom 5461S chip for
>> the PHY layer. This adds support for this PHY to the Intel igb driver.
>>
>> Signed-off-by: Alan Liebthal <alanl at cumulusnetworks.com>
>> Signed-off-by: Jonathan Toppins <jtoppins at cumulusnetworks.com>
>> ---
>>  drivers/net/ethernet/intel/igb/e1000_82575.c   |   20 +++++-
>>  drivers/net/ethernet/intel/igb/e1000_defines.h |    1 +
>>  drivers/net/ethernet/intel/igb/e1000_hw.h      |    1 +
>>  drivers/net/ethernet/intel/igb/e1000_phy.c     |   79
>> ++++++++++++++++++++++++
>>  drivers/net/ethernet/intel/igb/e1000_phy.h     |    2 +
>>  5 files changed, 102 insertions(+), 1 deletion(-)
>
> After at lot of discussion on these changes, we would like to you to use
> the PHYLib approach.  I know that means adding PHYLib support to our
> drivers, which we currently do not have.
>

Jeff,

Adding PHYLIB support to igb is what I was trying to do with my recent
series, by adding phy read/write functions which accept phy addr [1]
and by registering an mii_bus so that I could use a PHYLIB driver for
a switch we have connected to an i210 via MDIO [2].

I realize these didn't apply to your next-queue/dev-queue tree, but
could you give them a once-over and give me some direction on changes
I should make before I rebase them?

Regards,

Tim

[1]: http://patchwork.ozlabs.org/patch/466689/
[2]: http://patchwork.ozlabs.org/patch/466690/


More information about the Intel-wired-lan mailing list