[Intel-wired-lan] [PATCH] e1000e: fix logical error in flush_desc_rings

Brown, Aaron F aaron.f.brown at intel.com
Tue May 12 01:08:44 UTC 2015


> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Yanir Lubetkin
> Sent: Wednesday, April 22, 2015 9:25 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH] e1000e: fix logical error in
> flush_desc_rings
> 
> the condition under which the flush should occur was reversed.
> The fix should be applied before any HW reset (unless followed by bus
> reset)
> and before any power state transition from D0.
> if E1000_FEXTNVM7_NEED_DESCRING_FLUSH bit is set in FEXTNVM7 and TDLEN > 0
> the tx ring should be flushed. (fixes ~95% of the hang states).
> if the E1000_FEXTNVM7_NEED_DESCRING_FLUSH did not clear, we should also
> flush the RX ring. Bug was caught by Alexander Duyck during a code review
> when examining this fix.
> 
> Signed-off-by: Yanir Lubetkin <yanirx.lubetkin at intel.com>
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Tested-by: Aaron Brown <aaron.f.brown at intel.com>


More information about the Intel-wired-lan mailing list