[Intel-wired-lan] [PATCH 1/1] igb: Use ARRAY_SIZE instead fo sizeof(a)/sizeof(a[0])

Alex Gartrell alexgartrell at gmail.com
Tue Jun 30 20:38:19 UTC 2015


On Tue, Jun 30, 2015 at 1:16 PM, Fujinaka, Todd <todd.fujinaka at intel.com> wrote:

> I still would say no if I'm allowed, because to guarantee that this change - that I don't think fixes anything - works in all cases, we need to do an incredible amount of regression testing. Every variant of every Intel part that uses this driver (and there are many) should be tested and will end up being used by the community.
>

Validation is really simple: diff old_module.ko new_module.ko

And this is a good defensive measure, as it'll save you when someone
screws up and changes your array to a pointer to an array (you'll get
a build failure instead of 0).

-- 
Alex Gartrell <agartrell at fb.com>


More information about the Intel-wired-lan mailing list