[Intel-wired-lan] [PATCH 3/3] ipmr_free_table() should be called under taken rtnl_lock
Cong Wang
xiyou.wangcong at gmail.com
Tue Jul 7 17:30:36 UTC 2015
On Tue, Jul 7, 2015 at 10:25 AM, Vasily Averin <vvs at virtuozzo.com> wrote:
> On 07.07.2015 20:13, Cong Wang wrote:
>> On Tue, Jul 7, 2015 at 8:53 AM, Vasily Averin <vvs at virtuozzo.com> wrote:
>>> ipmr_free_table() calls unregister_netdevice_many() inside
>>> and changes net_todo_list protected by rtnl_lock
>>
>> Did you see any real bug?
>
> No, it was result of manual code review.
>
>> ipmr_free_table() is called in failure path, in this case there is no
>> device registered yet, so unregister should be just a nop?
>
> However may be it's better to mark this place for future anyway?
Then add a comment there. ;)
More information about the Intel-wired-lan
mailing list