[Intel-wired-lan] [PATCH] net: igb: implement high frequency periodic output signals

Brown, Aaron F aaron.f.brown at intel.com
Tue Aug 4 22:37:34 UTC 2015


> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Jeff Kirsher
> Sent: Thursday, July 23, 2015 3:00 PM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Richard Cochran
> Subject: [Intel-wired-lan] [PATCH] net: igb: implement high frequency
> periodic output signals
> 
> From: Richard Cochran <richardcochran at gmail.com>
> 
> In addition to interrupt driven target time output events, the i210
> also has two programmable clock outputs.  These clocks support periods
> between 16 nanoseconds and 140 milliseconds.  This patch implements
> the periodic output function using the clock outputs when possible,
> falling back to the target time for longer periods.
> 
> Signed-off-by: Richard Cochran <richardcochran at gmail.com>
> ---
>  drivers/net/ethernet/intel/igb/e1000_regs.h |  2 +
>  drivers/net/ethernet/intel/igb/igb_ptp.c    | 72 +++++++++++++++++++++---
> -----
>  2 files changed, 54 insertions(+), 20 deletions(-)

Checkpatch is throwing an over 80 character warning for this:
--------------------------------------------
WARNING: line over 80 characters
#139: FILE: drivers/net/ethernet/intel/igb/igb_ptp.c:561:
+                       tsauxc &= ~(TSAUXC_EN_TT1 | TSAUXC_EN_CLK1 | TSAUXC_ST1);

WARNING: line over 80 characters
#142: FILE: drivers/net/ethernet/intel/igb/igb_ptp.c:564:
+                       tsauxc &= ~(TSAUXC_EN_TT0 | TSAUXC_EN_CLK0 | TSAUXC_ST0);

total: 0 errors, 2 warnings, 0 checks, 134 lines checked

Your patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
--------------------------------------------

Aside from that,

Tested-by: Aaron Brown <aaron.f.brown at intel.com>


More information about the Intel-wired-lan mailing list