[Intel-wired-lan] [next PATCH S13 14/15] i40e: fix ip-ip GRE encapulation

Jesse Gross jesse at nicira.com
Fri Sep 11 02:12:01 UTC 2015


On Thu, Sep 10, 2015 at 2:53 PM, Nelson, Shannon
<shannon.nelson at intel.com> wrote:
>> From: Jesse Gross [mailto:jesse at nicira.com]
>> Sent: Wednesday, September 09, 2015 11:02 PM
>>
>
> Thanks, Jesse, for your perseverance.
>
>> >> To make a long story short, it looks like the actual problem here is
>> >> that only UDP tunnels are supported (since that is all that is
>> checked
>> >> in i40e_tx_enable_csum()). In that case, I think you could simply do:
>> >>
>> >> if ((protocol != IPPROTO_UDP))
>> >>     return features & ~(NETIF_F_ALL_CSUM | NETIF_F_GSO_MASK);
>
> Ah, now I see that the GRE support patch for i40e_tx_enable_csum() hasn't been pushed out yet.  This explains some of this discussion.  Okay - for the moment we're dropping this patch, to be reworked when the other patch gets pushed.
>
> I think you're right about simply dropping the use of vxlan_features_check() as it is too specific for our needs.  This will be part of the rework.

Thanks a lot for taking a look at it. Not trying to be a pain here - I
just want to make sure things work for all protocols/users.


More information about the Intel-wired-lan mailing list