[Intel-wired-lan] [next-queue 1/8] e1000: clean up the useless 'continue' statement

Rustad, Mark D mark.d.rustad at intel.com
Wed Sep 16 23:36:41 UTC 2015


> On Sep 16, 2015, at 2:09 PM, Alexander Duyck <alexander.duyck at gmail.com> wrote:
> 
> I have a very strong suspicion that the 0xFF value is an error, but I don't see the documentation for the ce4100 anywhere to be had on where they came up with that value.  If it is supposed to be the result of a register read failure I believe the result would already be 0 since there is a flag in the register that indicates a read status failue and if it is set the value isn't stored.

I think that it is likely that Alex is right, but the code cleanup should be separated from a functional change in any case, so for this patch, please leave it as 0xFF for now. I have asked someone more familiar with it to look further. Thanks.

--
Mark Rustad, Networking Division, Intel Corporation

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 841 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20150916/a1c6c6c8/attachment.asc>


More information about the Intel-wired-lan mailing list