[Intel-wired-lan] [net-next PATCH v2 2/3] i40e/i40evf: Drop useless "IN_NETPOLL" flag

Bowers, AndrewX andrewx.bowers at intel.com
Fri Sep 25 22:32:47 UTC 2015


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Alexander Duyck
> Sent: Thursday, September 24, 2015 9:05 AM
> To: netdev at vger.kernel.org; intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [net-next PATCH v2 2/3] i40e/i40evf: Drop useless
> "IN_NETPOLL" flag
> 
> The code in i40e and i40evf is using an "IN_NETPOLL" flag that has never
> added any value due to the fact that the Rx clean-up is handled in NAPI.
> As such the flag was set, the queue was scheduled via NAPI, and then polled
> from the netpoll controller and if any Rx packets were processed the were
> processed in the wrong context.
> 
> In addition the flag itself just added an unneeded conditional to the hot-path
> so it can safely be dropped and save us a few instructions.
> 
> Signed-off-by: Alexander Duyck <aduyck at mirantis.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e.h        |    1 -
>  drivers/net/ethernet/intel/i40e/i40e_main.c   |    2 --
>  drivers/net/ethernet/intel/i40e/i40e_txrx.c   |    7 +------
>  drivers/net/ethernet/intel/i40evf/i40e_txrx.c |    7 +------
>  drivers/net/ethernet/intel/i40evf/i40evf.h    |    2 --
>  5 files changed, 2 insertions(+), 17 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
Code changes present in tree


More information about the Intel-wired-lan mailing list