[Intel-wired-lan] [next PATCH S19 02/15] i40e: Change BUG_ON to WARN_ON in service event complete

Catherine Sullivan catherine.sullivan at intel.com
Wed Oct 21 23:47:03 UTC 2015


From: Shannon Nelson <shannon.nelson at intel.com>

There's no need to kill the thread and eventually the kernel in this
case.  In fact, the remainder of the code won't hurt anything anyway,
so just complain that we're here and move along.

Prompted by a recent Linus diatribe.

Signed-off-by: Shannon Nelson <shannon.nelson at intel.com>
Change-ID: Iec020d8bcfedffc1cd2553cc6905fd915bb3e670

---
Testing-hints: Internal code change only, check that the patch was
applied and compiled correctly.
 drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 62d58de..d2e4ea8 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -5758,7 +5758,7 @@ static void i40e_handle_lan_overflow_event(struct i40e_pf *pf,
  **/
 static void i40e_service_event_complete(struct i40e_pf *pf)
 {
-	BUG_ON(!test_bit(__I40E_SERVICE_SCHED, &pf->state));
+	WARN_ON(!test_bit(__I40E_SERVICE_SCHED, &pf->state));
 
 	/* flush memory to make sure state is correct before next watchog */
 	smp_mb__before_atomic();
-- 
1.9.3



More information about the Intel-wired-lan mailing list