[Intel-wired-lan] [PATCH] ixgbe: Wait for 1ms, not 1us, after RST
dan.streetman at canonical.com
dan.streetman at canonical.com
Tue Oct 27 00:16:11 UTC 2015
From: Dan Streetman <dan.streetman at canonical.com>
The driver currently waits 1us after issuing a RST, but the spec
requires it to wait 1ms.
Signed-off-by: Dan Streetman <dan.streetman at canonical.com>
Signed-off-by: Dan Streetman <ddstreet at ieee.org>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c
index 4e75843..147bc65 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c
@@ -113,7 +113,12 @@ mac_reset_top:
/* Poll for reset bit to self-clear indicating reset is complete */
for (i = 0; i < 10; i++) {
- udelay(1);
+ /* sec 8.2.4.1.1 :
+ * programmers must wait approximately 1 ms after setting before
+ * attempting to check if the bit has cleared or to access (read
+ * or write) any other device register.
+ */
+ mdelay(1);
ctrl = IXGBE_READ_REG(hw, IXGBE_CTRL);
if (!(ctrl & IXGBE_CTRL_RST_MASK))
break;
--
2.5.0
More information about the Intel-wired-lan
mailing list