[Intel-wired-lan] [next PATCH 1/2] i40e: fix: do not sleep in netdev_ops

Bowers, AndrewX andrewx.bowers at intel.com
Fri Nov 6 17:51:31 UTC 2015


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Jesse Brandeburg
> Sent: Thursday, November 05, 2015 5:01 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH 1/2] i40e: fix: do not sleep in
> netdev_ops
> 
> The driver was being called by vlan, bonding, teaming operations that
> expected to be able to hold locks like rcu_read_lock().
> 
> This causes the driver to be held to the requirement to not sleep, and was
> found by the kernel debug options for checking sleep inside critical section,
> and the locking validator.
> 
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg at intel.com>
> Change-ID: Ibc68c835f5ffa8ffe0638ffe910a66fc5649a7f7
> 
> ---
> 
> Testing Hints (required if no HSD): add and remove vlan, over and under
> bonding and teaming driver, add and delete mac address, run debug kernel
> with lock validator.
> ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 44 +++++++++++++------------
> ----
>  1 file changed, 20 insertions(+), 24 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
Patch code changes correctly applied,  add/delete mac/vlan operations lock and unlock normally


More information about the Intel-wired-lan mailing list