[Intel-wired-lan] [PATCH] i40e: Fix i40e_print_features() VEB mode output

David Miller davem at davemloft.net
Wed Dec 2 20:48:00 UTC 2015


From: Joe Perches <joe at perches.com>
Date: Wed, 02 Dec 2015 02:12:29 -0800

> On Wed, 2015-12-02 at 01:56 -0800, Jeff Kirsher wrote:
>> On Wed, 2015-12-02 at 00:38 -0800, Joe Perches wrote:
>> > Commit 7fd89545f337 ("i40e: remove BUG_ON from feature string
>> > building")
>> > added defective output when I40E_FLAG_VEB_MODE_ENABLED was set in
>> > function i40e_print_features.
>> > 
>> > Fix it.
>> > 
>> > Miscellanea:
>> > 
>> > o Remove unnecessary string variable
>> > o Add space before not after fixed strings
>> > o Use kmalloc not kzalloc
>> > o Don't initialize i to 0, use result of first snprintf
>> > 
>> > Noticed-by: Sergei Shtylyov <sergei.shtylyov at cogentembedded.com>
>> 
>> Don't you mean Reported-by?  I am not aware of Noticed-by as being a
>> recognized signature.
> 
> At least for the get_maintainer script, "<anything>-by:" is a signature

Is patchwork using the same regexp?  If not, for the time being don't
user non-standard tags, and furthermore please ask the patchwork folks
to use something similar to getmaintainer.pl

Thanks.


More information about the Intel-wired-lan mailing list