[Intel-wired-lan] [net-next v2] i40e: Fix i40e_print_features() VEB mode output

Bowers, AndrewX andrewx.bowers at intel.com
Thu Dec 3 16:46:09 UTC 2015


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Jeff Kirsher
> Sent: Thursday, December 03, 2015 4:21 AM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Joe Perches <joe at perches.com>; netdev at vger.kernel.org;
> sergei.shtylyov at cogentembedded.com
> Subject: [Intel-wired-lan] [net-next v2] i40e: Fix i40e_print_features() VEB
> mode output
> 
> From: Joe Perches <joe at perches.com>
> 
> Commit 7fd89545f337 ("i40e: remove BUG_ON from feature string building")
> added defective output when I40E_FLAG_VEB_MODE_ENABLED was set in
> function i40e_print_features.
> 
> Fix it.
> 
> Miscellanea:
> 
> - Remove unnecessary string variable
> - Add space before not after fixed strings
> - Use kmalloc not kzalloc
> - Don't initialize i to 0, use result of first snprintf
> 
> Reported-by: Sergei Shtylyov <sergei.shtylyov at cogentembedded.com>
> Signed-off-by: Joe Perches <joe at perches.com>
> ---
> v2: fixed patch conflicts when trying to apply to my next-queue tree
>     (dev-queue branch), also fixed "Noticed-by" to the more acceptable
>     "Reported-by"
> 
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 42 +++++++++++++------------
> ----
>  1 file changed, 19 insertions(+), 23 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
Patch code changes correctly applied, features correctly print on driver init.


More information about the Intel-wired-lan mailing list