[Intel-wired-lan] [PATCH] igb: Enable RSS for i211 adapter

[Fujinaka, Todd]

As I was composing this email, I noticed the same thing. I'll double-check to make sure the comment is actually necessary.

Thanks Alex!

Todd Fujinaka
Software Application Engineer
Networking Division (ND)
Intel Corporation
todd.fujinaka at intel.com
(503) 712-4565


-----Original Message-----
From: Alex Duyck [mailto:aduyck at mirantis.com] 
Sent: Thursday, December 17, 2015 10:43 AM
To: Fujinaka, Todd
Cc: intel-wired-lan at lists.osuosl.org; alexander.duyck at gmail.com; Tal Abudi
Subject: Re: [Intel-wired-lan] [PATCH] igb: Enable RSS for i211 adapter

On Thu, Dec 17, 2015 at 10:37 AM, Fujinaka, Todd <todd.fujinaka at intel.com> wrote:
> I've spent too much time looking into this. I think this was added when someone looked for the register value and it was the same as E1000_MRQC_ENABLE_RSS_8Q and disabled i211 because it doesn't have 8 queues.
>
> I've been asked if you could spin this to add a comment that the two values are the same (E1000_MRQC_ENABLE_RSS_8Q and E1000_MRQC_ENABLE_RSS_4Q).

That would be even more confusing since the value that is being used is RSS_4Q so I am not sure where the 8Q comes into play.  I guess at some point it was renamed?  Feel free to modify the code however you want.  I was just going through and trying to figure out the issue that had been reported and I noticed it wasn't getting enabled.  It's fine with me if you drop me as author if you guys rewrite the patch and add a comment.  You could probably just add a Suggested-by credit to the patch you generate.

- Alex