[Intel-wired-lan] [PATCH] igb: fix itnull.cocci warnings

Julia Lawall julia.lawall at lip6.fr
Wed Dec 23 12:52:28 UTC 2015


The index variable of list_for_each_entry_safe should never be NULL.

Generated by: scripts/coccinelle/iterators/itnull.cocci

CC: Gangfeng Huang <gangfeng.huang at ni.com>
Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
---

 igb_cdev.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/net/ethernet/intel/igb/igb_cdev.c
+++ b/drivers/net/ethernet/intel/igb/igb_cdev.c
@@ -411,8 +411,7 @@ static int igb_close_file(struct inode *

 		list_for_each_entry_safe(userpage, tmp,
 					 &adapter->user_page_list, page_node) {
-			if (userpage)
-				igb_free_page(adapter, userpage);
+			igb_free_page(adapter, userpage);
 		}
 	}
 	mutex_unlock(&adapter->user_page_mutex);


More information about the Intel-wired-lan mailing list