[Intel-wired-lan] [next PATCH S26 11/12] i40e: avoid large memcpy by assigning struct
Deepthi Kavalur
deepthi.kavalur at intel.com
Mon Jan 4 18:33:11 UTC 2016
From: Jacob Keller <jacob.e.keller at intel.com>
Assign the i40e_pf structure directly instead of using a large memcpy,
which avoids a sparse warning and lets the compiler optimize the copy
since it knows the size of the structure in advance.
Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
Reviewed-by: Brandeburg, Jesse <jesse.brandeburg at intel.com>
Change-ID: I17604e23be2616521eb760290befcb767b52b3f7
---
drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
index 10744a6..2c0848f 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
@@ -185,9 +185,11 @@ static ssize_t i40e_dbg_dump_write(struct file *filp,
if (i40e_dbg_prep_dump_buf(pf, buflen)) {
p = i40e_dbg_dump_buf;
- len = sizeof(struct i40e_pf);
- memcpy(p, pf, len);
- p += len;
+ /* avoid use of memcpy here due to sparse warning
+ * about copy size.
+ */
+ *((struct i40e_pf *)p) = *pf;
+ p += sizeof(struct i40e_pf);
len = (sizeof(struct i40e_aq_desc)
* pf->hw.aq.num_asq_entries);
--
2.1.0
More information about the Intel-wired-lan
mailing list