[Intel-wired-lan] [v2 next PATCH S27 08/15] i40e/i40evf: don't lose interrupts

Bowers, AndrewX andrewx.bowers at intel.com
Wed Jan 20 19:19:04 UTC 2016


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Joshua Hay
> Sent: Wednesday, January 13, 2016 4:52 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [v2 next PATCH S27 08/15] i40e/i40evf: don't lose
> interrupts
> 
> From: Jesse Brandeburg <jesse.brandeburg at intel.com>
> 
> While re-enabling interrupts the driver would clear all pending causes. This
> meant that if an interrupt was generated while the driver was cleaning or
> polling with interrupts disabled, then that interrupt was lost.  This could cause
> a queue to become dead, especially for receive.  Refactored the enable_icr0
> function in order to allow it to be decided by the caller whether the
> CLEARPBA (clear pending
> events) bit will be set while re-enabling the interrupt.
> 
> Also update copyright year in file headers.
> 
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg at intel.com>
> Change-ID: Ic1db100a05e13c98919057696db147a258ca365a
> ---
> Testing Hints: use pktgen or a traffic generator to send packets to the device
> and force it to enter polling.  If all queues are in use, usually a few of the
> queues will quit receiving.
> 
>  drivers/net/ethernet/intel/i40e/i40e.h             |  7 +++++--
>  drivers/net/ethernet/intel/i40e/i40e_main.c        | 11 ++++++-----
>  drivers/net/ethernet/intel/i40e/i40e_txrx.c        |  6 ++++--
>  drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c |  4 ++--
>  drivers/net/ethernet/intel/i40evf/i40e_txrx.c      |  4 +++-
>  5 files changed, 20 insertions(+), 12 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
Patch code changes correctly applied, queues don't drop when hammered with traffic


More information about the Intel-wired-lan mailing list