[Intel-wired-lan] [next PATCH S28 12/15] i40evf: set adapter state on reset failure

Bowers, AndrewX andrewx.bowers at intel.com
Thu Jan 21 00:24:38 UTC 2016


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Joshua Hay
> Sent: Friday, January 15, 2016 2:33 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S28 12/15] i40evf: set adapter state on
> reset failure
> 
> From: Mitch Williams <mitch.a.williams at intel.com>
> 
> If a reset fails to complete, the driver gets its affairs in order and awaits the
> cold solace of rmmod. Unfortunately, it was not properly setting the adapter
> state, which would cause a panic on rmmod, instead of the desired surcease.
> 
> Set the adapter state to DOWN in this case, and avoid a panic.
> 
> Signed-off-by: Mitch Williams <mitch.a.williams at intel.com>
> Change-ID: I6fdd9906da52e023f8dc744f7da44b5d95278ca9
> ---
> Testing Hints: Execute CORER on the PF and see if you can get into the state
> where the VF reset never completed. Then rmmod i40evf.
> 
>  drivers/net/ethernet/intel/i40evf/i40evf_main.c | 1 +
>  1 file changed, 1 insertion(+)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
Patch code changes correctly applied, no errors/panics detected after multiple resets


More information about the Intel-wired-lan mailing list