[Intel-wired-lan] [next PATCH v2 08/15] i40e/i40evf: Do not write to descriptor unless we complete

[Singhai, Anjali]

Thanks a lot Alex for the series! Much cleaner and you caught a lot of IPv6 issues.

Anjali

> -----Original Message-----
> From: Alexander Duyck [mailto:alexander.duyck at gmail.com]
> Sent: Friday, January 22, 2016 1:27 PM
> To: Singhai, Anjali
> Cc: Alexander Duyck; intel-wired-lan; Kirsher, Jeffrey T
> Subject: Re: [Intel-wired-lan] [next PATCH v2 08/15] i40e/i40evf: Do not write
> to descriptor unless we complete
> 
> On Fri, Jan 22, 2016 at 1:23 PM, Singhai, Anjali
> <anjali.singhai at intel.com> wrote:
> >
> >
> > On 1/21/2016 4:27 PM, Alexander Duyck wrote:
> >>
> >>         __be16 frag_off;
> >>         u8 l4_proto = 0;
> >>         ip.hdr = skb_network_header(skb);
> >>         l4.hdr = skb_transport_header(skb);
> >>   +     /* words in MACLEN + dwords in IPLEN + dwords in L4Len */
> >
> >
> > May be the comment should say words in MACLEN and as the other fields
> get
> > added later, build upon it...
> 
> You are right, this is just MACLEN.  I can update the comment for a v3.
> 
> >
> >> +       offset = ((ip.hdr - skb->data) / 2) <<
> >> +                I40E_TX_DESC_LENGTH_MACLEN_SHIFT;
> >> +
> >
> >
> >>                 exthdr = ip.hdr + sizeof(*ip.v6);
> >>                 l4_proto = ip.v6->nexthdr;
> >> @@ -2487,34 +2492,33 @@ static void i40e_tx_enable_csum(struct
> sk_buff
> >> *skb, u32 *tx_flags,
> >>         }
> >>         /* Now set the td_offset for IP header length */
> >
> >
> > Comment needs to be fixed
> 
> Will update for v3.
> 
> >
> >> -       *td_offset = ((l4.hdr - ip.hdr) / 4) <<
> >> I40E_TX_DESC_LENGTH_IPLEN_SHIFT;
> >> -       /* words in MACLEN + dwords in IPLEN + dwords in L4Len */
> >> -       *td_offset |= (skb_network_offset(skb) >> 1) <<
> >> -                      I40E_TX_DESC_LENGTH_MACLEN_SHIFT;
> >> +       offset |= ((l4.hdr - ip.hdr) / 4) <<
> >> I40E_TX_DESC_LENGTH_IPLEN_SHIFT;
> >>
> >
> >
> > _______________________________________________
> > Intel-wired-lan mailing list
> > Intel-wired-lan at lists.osuosl.org
> > http://lists.osuosl.org/mailman/listinfo/intel-wired-lan