[Intel-wired-lan] [next PATCH v3 04/15] i40e/i40evf: Consolidate all header changes into TSO function
Bowers, AndrewX
andrewx.bowers at intel.com
Wed Jan 27 16:14:42 UTC 2016
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Alexander Duyck
> Sent: Sunday, January 24, 2016 9:17 PM
> To: intel-wired-lan at lists.osuosl.org; Kirsher, Jeffrey T
> <jeffrey.t.kirsher at intel.com>
> Subject: [Intel-wired-lan] [next PATCH v3 04/15] i40e/i40evf: Consolidate all
> header changes into TSO function
>
> This patch goes through and pulls all of the spots where we were updating
> either the TCP or IP checksums in the TSO and checksum path into the TSO
> function. The general idea here is that we should only be updating the
> header after we verify we have completed a skb_cow_head check to verify
> the head is writable.
>
> One other advantage to doing this is that it makes things much more obvious.
> For example, in the case of IPv6 there was one spot where the offset of the
> IPv4 header checksum was being updated which is obviously incorrect.
>
> Signed-off-by: Alexander Duyck <aduyck at mirantis.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 44 +++++++++++++++-------
> ---
> drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 44 +++++++++++++++------
> ----
> 2 files changed, 52 insertions(+), 36 deletions(-)
Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
TSO works as expected, checksum offload works as expected, code changes properly applied
More information about the Intel-wired-lan
mailing list