[Intel-wired-lan] [next PATCH S28 09/15] i40e: Do not disable queues in the Legacy/MSI Interrupt handler

Bowers, AndrewX andrewx.bowers at intel.com
Wed Jan 27 20:29:46 UTC 2016


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Joshua Hay
> Sent: Friday, January 15, 2016 2:33 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S28 09/15] i40e: Do not disable
> queues in the Legacy/MSI Interrupt handler
> 
> From: Anjali Singhai Jain <anjali.singhai at intel.com>
> 
> The queues should never be enabled/disabled in the interrupt handler,
> ICR0 interrupt enable should be the only thing that needs to be dynamically
> changed in the handler.
> 
> This patch fixes that. Without this patch X722 platforms were seeing weird
> ping timings when in Legacy mode since it takes a whole lot of time for the
> HW/FW to re-enable queues.
> 
> Signed-off-by: Anjali Singhai Jain <anjali.singhai at intel.com>
> Change-ID: If065afc45d81c5a19d4a94a00cd5b8f61cefc40c
> ---
> Testing Hints (Required if no HSD): Test with legacy mode enabled.
> 
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 16 ++++++----------
> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 13 -------------
>  2 files changed, 6 insertions(+), 23 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
Patch code changes correctly applied, ping times normal/consistent on X722 in Legacy mode


More information about the Intel-wired-lan mailing list