[Intel-wired-lan] [PATCH net-next V2 1/6] i40e: call ndo_stop() instead of dev_close() when running offline selftest

[Bowers, AndrewX]

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Stefan Assmann
> Sent: Wednesday, February 03, 2016 12:21 AM
> To: intel-wired-lan at lists.osuosl.org
> Cc: netdev at vger.kernel.org; davem at davemloft.net; sassmann at kpanic.de
> Subject: [Intel-wired-lan] [PATCH net-next V2 1/6] i40e: call ndo_stop()
> instead of dev_close() when running offline selftest
> 
> Calling dev_close() causes IFF_UP to be cleared which will remove the
> interfaces routes and some addresses. That's probably not what the user
> intended when running the offline selftest. Besides this does not happen if
> the interface is brought down before the test, so the current behaviour is
> inconsistent.
> Instead call the net_device_ops ndo_stop function directly and avoid
> touching IFF_UP at all.
> 
> Signed-off-by: Stefan Assmann <sassmann at kpanic.de>
> ---
>  drivers/net/ethernet/intel/i40e/i40e.h         | 2 +-
>  drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 4 ++--
>  drivers/net/ethernet/intel/i40e/i40e_main.c    | 4 ----
>  3 files changed, 3 insertions(+), 7 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
Interface did not drop addresses/routes during offline ethtool self-test.