[Intel-wired-lan] [PATCH 1/3] igb: Enable the ethtool interface fo Rx filter

Gangfeng Huang gangfeng.huang at ni.com
Thu Feb 25 02:52:12 UTC 2016


Hi Jeff,

Thank you very for the comments and suggestion,  Because I am not vary clear about the process of submit commit,  I directly fix arron's comments in my yesterday's patch.  I will recreate this patches to update the description and  fix aaron's comments in a separate patch.

-----Original Message-----
From: Jeff Kirsher [mailto:jeffrey.t.kirsher at intel.com] 
Sent: 2016年2月25日 4:30
To: Gangfeng Huang <gangfeng.huang at ni.com>; intel-wired-lan at lists.osuosl.org
Cc: Ruhao Gao <ruhao.gao at ni.com>; John Ronciak <john.ronciak at intel.com>
Subject: Re: [Intel-wired-lan] [PATCH 1/3] igb: Enable the ethtool interface fo Rx filter

On Wed, 2016-02-24 at 17:06 +0800, Gangfeng wrote:
> From: Gangfeng Huang <gangfeng.huang at ni.com>
> 
> This patch is meant to allow for nfc to insert and remove Rx filter by 
> ethtool. Ethtool interface has it's own rules manager
> 
> Show all filters:
> $ ethtool -n eth0
> 4 RX rings available
> Total 2 rules
> 
> Signed-off-by: Ruhao Gao <ruhao.gao at ni.com>
> Signed-off-by: Gangfeng Huang <gangfeng.huang at ni.com>
> ---
>  drivers/net/ethernet/intel/igb/igb.h         |   31 +++++
>  drivers/net/ethernet/intel/igb/igb_ethtool.c |  193
> ++++++++++++++++++++++++++
>  drivers/net/ethernet/intel/igb/igb_main.c    |   45 ++++++
>  3 files changed, 269 insertions(+)

What does NFC mean?  It is proper etiquette to spell out all acronyms before using them, especially when they are not universally known.

Did you address Aaron Brown questions and concerns?  I do not see any change log to this series of patches, so I do not think you changed anything from the first time you submitted it.  I rejected this the first time around because of the questions and concerns Aaron brought up, so if you are going to ignore Aaron, you might as well forget about getting these changes into the kernel.

Also for the amount of changes you are making to the igb, we will need a clearly defined justification as to why this is needed.  Your sparse patch description needs more information to help us understand why we need these changes.


More information about the Intel-wired-lan mailing list