[Intel-wired-lan] [PATCH 2/2] fm10k: use fm10k_stats structures for per-queue statistics

Singh, Krishneil K krishneil.k.singh at intel.com
Thu Feb 25 20:32:36 UTC 2016



-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Jacob Keller
Sent: Friday, February 5, 2016 10:43 AM
To: Intel Wired LAN <intel-wired-lan at lists.osuosl.org>
Subject: [Intel-wired-lan] [PATCH 2/2] fm10k: use fm10k_stats structures for per-queue statistics

This will allow us numerous advantages, including

(a) rework the per-queue stats to only display active queues, reducing
    clutter on the output. This is important since we often don't have
    all possible queues enabled.

(b) use the new streamlined helper functions, reducing duplicate code
    and increasing readability of the stats logic

(c) add the additional per-tx and per-rx statistics when
    debug-statistics is enabled, which may be helpful for future debug
    work.

The primary motivation for this change is (a), though (b) and (c) are useful additions which were noticed while developing the change.

Note that this code currently assumes we have the same number of Tx and Rx queues which should be true of our driver pretty much always. Even if there are a non equal number of Tx and Rx queues, the only result will be a few extra statistics displaying 0s. This is better than the current setup which shows every disabled queue with all 0s.

Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
---
Tested-by: Krishneil Singh <Krishneil.k.singh at intel.com>



More information about the Intel-wired-lan mailing list