[Intel-wired-lan] [next PATCH 2/3] ixgbe: Store VXLAN port number in network order

Bowers, AndrewX andrewx.bowers at intel.com
Tue Mar 1 18:23:27 UTC 2016


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Alexander Duyck
> Sent: Monday, January 25, 2016 7:36 PM
> To: intel-wired-lan at lists.osuosl.org; Kirsher, Jeffrey T
> <jeffrey.t.kirsher at intel.com>
> Subject: [Intel-wired-lan] [next PATCH 2/3] ixgbe: Store VXLAN port number
> in network order
> 
> The VXLAN port number should be stored in network order instead of in host
> order as it is accessed from the hot-path in ATR.  This way we can avoid
> having to do any byte swaps in order to validate the port number.
> 
> I moved the vxlan_port value into a hole in the read-mostly region of the
> adapter struct.  This way it should be in a warm cache-line instead of in some
> isolated region in memory when it needs to be accessed.
> 
> In addition I went through and stripped a bunch of unneeded ifdef flags since
> having an extra variable present doesn't really hurt anything and makes the
> code easier to read.  I also went through and dropped the NETIF_F_RXCSUM
> flag which was being set in hw_encap_features but provides no value as the
> flag is not evaluated in the Rx path.
> 
> Signed-off-by: Alexander Duyck <aduyck at mirantis.com>
> ---
> 
> Testing Hints:
> Test with X550 to verify that VXLAN offloads are still occurring as they should.
> 
>  drivers/net/ethernet/intel/ixgbe/ixgbe.h      |    8 +--
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |   61 +++++++-----------------
> -
>  2 files changed, 20 insertions(+), 49 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
VxLAN offload works correctly


More information about the Intel-wired-lan mailing list