[Intel-wired-lan] [PATCH 1/5] i40e/i40evf: Fix handling of boolean logic in polling routines

Bowers, AndrewX andrewx.bowers at intel.com
Thu Mar 10 18:37:15 UTC 2016


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Alexander Duyck
> Sent: Monday, March 07, 2016 9:30 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH 1/5] i40e/i40evf: Fix handling of boolean
> logic in polling routines
> 
> In the polling routines for i40e and i40evf we were using bitwise operators to
> avoid the side effects of the logical operators, specifically the fact that if the
> first case is true with "||" we skip the second case, or if it is false with "&&"
> we skip the second case.  This fixes an earlier patch that converted the
> bitwise operators over to the logical operators and instead replaces the
> entire thing with just an if statement since it should be more readable what
> we are trying to do this way.
> 
> Fixes: 1a36d7fadd14 ("i40e/i40evf: use logical operators, not bitwise")
> Signed-off-by: Alexander Duyck <aduyck at mirantis.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_txrx.c   |   13 ++++++++-----
>  drivers/net/ethernet/intel/i40evf/i40e_txrx.c |   13 ++++++++-----
>  2 files changed, 16 insertions(+), 10 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
Driver correctly builds and passes traffic normally.


More information about the Intel-wired-lan mailing list