[Intel-wired-lan] [PATCH v2 net-next] ixgbe: Avoid unaligned access in ixgbe_atr() for LLC packets

Sowmini Varadhan sowmini.varadhan at oracle.com
Mon Mar 14 17:59:09 UTC 2016


On (03/14/16 10:55), Alexander Duyck wrote:
> 
> One other thing I forgot to mention is that we don't support ARP so
> that check could be dropped.  The ATR code only supports IPv4 or IPv6
> with TCP.

I did notice that, but I left it in place because (a) it comes down
the stack with the NET_IP_ALIGNment and (b) ARP is only sent over
Ethernet II (there is no LLC SAP for ARP, which is a big reason
why ipv4 is not sent over llc, despite rfc 1042).

I figured it would not hurt to pass it down, in case we decide
to do something clever with it in the future.

--Sowmini



More information about the Intel-wired-lan mailing list