[Intel-wired-lan] [PATCH V2 5/5] ixgbe: Take manageability semaphore for firmware commands

Rustad, Mark D mark.d.rustad at intel.com
Mon Mar 14 21:11:15 UTC 2016

Mark D Rustad <mark.d.rustad at intel.com> wrote:

> We need to take the manageability semaphore when issuing firmware
> commands to avoid problems. With this in place, the semaphore is
> no longer taken in the ixgbe_set_fw_drv_ver_generic function, since
> it will now always be taken by the ixgbe_host_interface_command
> function.
> Signed-off-by: Mark Rustad <mark.d.rustad at intel.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_common.c |   30 +++++++++++++++--------
>  1 file changed, 19 insertions(+), 11 deletions(-)


I would like this patch considered for -net since it is a spec violation on  
all X550 devices and can result in NVM checksum errors, bad MAC addresses  
or other unpredictable behavior. It could also be usefully backported to  
any version that includes the ixgbe_x550.c file.

Mark Rustad, Networking Division, Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 841 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160314/ad254f96/attachment.asc>

More information about the Intel-wired-lan mailing list