[Intel-wired-lan] [next PATCH S30 v3 05/13] i40e: Remove msix only if created

Bowers, AndrewX andrewx.bowers at intel.com
Tue Mar 15 18:36:56 UTC 2016

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of ajdayana
> Sent: Thursday, March 10, 2016 3:00 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S30 v3 05/13] i40e: Remove msix only
> if created
> From: Shannon Nelson <shannon.nelson at intel.com>
> When cleaning up the interrupt handling, clean up the irqs only if we actually
> got them set up.  There are a couple of error recovery paths that were
> violating this and causing the kernel a bit of indigestion.
> Testing Hints:
> Inject an error om the i40e_probe() that puts the driver into the debug
> mode, then remove the driver.  Often this causes a NULL pointer warning
> from the i40e_remove trace.
> Reviewed-by: Williams, Mitch A <mitch.a.williams at intel.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
Driver will remove cleanly in error state

More information about the Intel-wired-lan mailing list