[Intel-wired-lan] [next PATCH S30 v3 07/13] i40e: Remove timer and task only if created

Bowers, AndrewX andrewx.bowers at intel.com
Tue Mar 15 18:37:31 UTC 2016


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of ajdayana
> Sent: Thursday, March 10, 2016 3:00 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [next PATCH S30 v3 07/13] i40e: Remove timer and
> task only if created
> 
> From: Shannon Nelson <shannon.nelson at intel.com>
> 
> In some error scenarios, we may find ourselves trying to remove a non-
> existent timer or worktask.  This causes the kernel some bit of consternation,
> so don't do it.
> 
> Testing Hints: Inject an error into the i40e_probe before these are created
> and see if you can get a clean remove.
> 
> Signed-off-by: Nelson, Shannon <shannon.nelson at intel.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
Driver will remove cleanly in error state


More information about the Intel-wired-lan mailing list