[Intel-wired-lan] [PATCH v1 3/9] fm10k: correctly handle LPORT_MAP error

Singh, Krishneil K krishneil.k.singh at intel.com
Wed Apr 13 22:35:00 UTC 2016


-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Jacob Keller
Sent: Friday, April 1, 2016 4:18 PM
To: Intel Wired LAN <intel-wired-lan at lists.osuosl.org>
Subject: [Intel-wired-lan] [PATCH v1 3/9] fm10k: correctly handle LPORT_MAP error

Currently, any error responses from the switch manager after an LPORT_MAP request are silently ignored. At most the mailbox message will be reported as an error. This can result in unexpected behavior when the switch manager has configured a port with zero bandwidth. Add support for reading the fm10k_swapi_error structure from LPORT_MAP responses.

If the message contains the necessary TLV and has a non-zero error code, report link down, clear the dglort_map, and delay the next get_host_state call by a reasonable delay. Also log an error message indicating that the LPORT_MAP request failed.

The delay ensures preventing an interrupt storm on the switch manager, and reduces the number of mailbox messages we send in this scenario drastically.

Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
---


Tested-by: Krishneil Singh <Krishneil.k.singh at intel.com>



More information about the Intel-wired-lan mailing list