[Intel-wired-lan] [next PATCH S35 11/14] i40e/i40evf: Refactor receive routine

Alexander Duyck alexander.duyck at gmail.com
Fri Apr 15 19:21:24 UTC 2016


On Fri, Apr 15, 2016 at 11:19 AM, Jesse Brandeburg
<jesse.brandeburg at intel.com> wrote:
> On Fri, 15 Apr 2016 10:25:37 -0700
> Alexander Duyck <alexander.duyck at gmail.com> wrote:
>> If due to only the size I really think this should probably be split
>> into two patches.  One for the VF and one for the PF.  That way we
>> should only be looking at about 1000 lines of change per patch instead
>> of 2000 which becomes a bit unwieldy.  If nothing else it makes the
>> reviews easier to read as we don't end up with a novel with review
>> comments scattered throughout.
>
> Thanks for all your comments Alex, they're really useful.  I can split
> the patches into (at least) two.
>
> As far as the comments go, most seem to be tweaks/tuning, and unless I
> missed it not any bugs yet (but I know the patch was huge)
>
> So, would it be at all reasonable to proceed with the code basically
> unchanged except for splitting it up, if no bugs are noticed during
> review?  Then I will follow up with a cleanup series?

The only big issue I saw is the RXE bit check being dropped
completely.  If you can incorporate that into the cleanup_headers
function then I would say the rest is mostly just performance bits
that can be cleaned up later.

- Alex


More information about the Intel-wired-lan mailing list