[Intel-wired-lan] [PATCH] ixgbe: use msleep for long delays

Rustad, Mark D mark.d.rustad at intel.com
Mon Apr 25 22:01:59 UTC 2016


AndrewX <andrewx.bowers at intel.com> wrote:

>> -----Original Message-----
>> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
>> Behalf Of Arnd Bergmann
>> Sent: Saturday, April 16, 2016 1:35 PM
>> To: Kirsher, Jeffrey T <jeffrey.t.kirsher at intel.com>
>> Cc: Arnd Bergmann <arnd at arndb.de>; linux-kernel at vger.kernel.org; intel-
>> wired-lan at lists.osuosl.org; netdev at vger.kernel.org
>> Subject: [Intel-wired-lan] [PATCH] ixgbe: use msleep for long delays
>>
>> The newly added x550em_a support causes a link failure on ARM because of
>> an overly long time passed into udelay():
>>
>> ERROR: "__bad_udelay" [drivers/net/ethernet/intel/ixgbe/ixgbe.ko]
>> undefined!
>>
>> There are multiple variants of the ixgbe_acquire_swfw_sync_*() function,
>> and the other ones all use msleep(), so we can safely assume that all  
>> callers
>> are allowed to sleep, which makes msleep() a better replacement than
>> mdelay().
>>
>> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
>> Fixes: 49425dfc7451 ("ixgbe: Add support for x550em_a 10G MAC type")
>> ---
>>  drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
> Able to cross-compile driver for ARM architecture without sleep errors or  
> warnings from compiler
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at lists.osuosl.org
> http://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Was this functionally tested? I am concerned that we can get sleeping while  
atomic errors from ethtool operations with this in place. Compiling  
successfully does not test that.

--
Mark Rustad, Networking Division, Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 841 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160425/2e752888/attachment.asc>


More information about the Intel-wired-lan mailing list