[Intel-wired-lan] [PATCH v1] checkpatch.pl: seed camelcase from the provided kernel tree root

Bowers, AndrewX andrewx.bowers at intel.com
Wed May 11 15:07:38 UTC 2016


I think I found an issue, if I run the checkpatch against bb152c3 (Refactor ethtool get settings)  it 
gives me an "unknown option: -C" error and then a bunch of Avoid 
CamelCase checks (See attachment)

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Jacob Keller
> Sent: Thursday, May 05, 2016 4:11 PM
> To: Intel Wired LAN <intel-wired-lan at lists.osuosl.org>
> Subject: [Intel-wired-lan] [PATCH v1] checkpatch.pl: seed camelcase from
> the provided kernel tree root
> 
> When checkpatch.pl is run without a git tree, it seeds the camelcase includes
> from the $root parameter. However, it does not use the $root directory
> when seeding for a git tree. Fix this by using "-C $root" so that a user may run
> checkpatch with the --root parameter pointing to a valid kernel source tree.
> In addition, when generating the list of files to check, we must also prefix
> each file with the $root parameter, in order to properly locate the file when
> searching.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> ---
>  scripts/checkpatch.pl | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index
> d574d13ba963..8ec10e8cff73 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -665,8 +665,8 @@ sub seed_camelcase_includes {
> 
>  	$camelcase_seeded = 1;
> 
> -	if (-e ".git") {
> -		my $git_last_include_commit = `git log --no-merges --
> pretty=format:"%h%n" -1 -- include`;
> +	if (-e "$root/.git") {
> +		my $git_last_include_commit = `git -C $root log --no-merges
> +--pretty=format:"%h%n" -1 -- include`;
>  		chomp $git_last_include_commit;
>  		$camelcase_cache = ".checkpatch-
> camelcase.git.$git_last_include_commit";
>  	} else {
> @@ -693,9 +693,10 @@ sub seed_camelcase_includes {
>  		return;
>  	}
> 
> -	if (-e ".git") {
> -		$files = `git ls-files "include/*.h"`;
> +	if (-e "$root/.git") {
> +		$files = `git -C $root ls-files "include/*.h"`;
>  		@include_files = split('\n', $files);
> +		@include_files = map("$root/$_", @include_files);
>  	}
> 
>  	foreach my $file (@include_files) {
> --
> 2.8.1.493.g7b22612
> 
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at lists.osuosl.org
> http://lists.osuosl.org/mailman/listinfo/intel-wired-lan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: checkpatch output.jpg
Type: image/jpeg
Size: 106605 bytes
Desc: checkpatch output.jpg
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160511/48fb237f/attachment-0001.jpg>


More information about the Intel-wired-lan mailing list